Apply suggestions from code review

Co-authored-by: Janine Liu <32226860+j9liu@users.noreply.github.com>
CesiumGS · May 5, 2022 · c78ba69 · c78ba69
1 parent ebfbde1
commit c78ba69
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/Source/Scene/ModelAnimation.js b/Source/Scene/ModelAnimation.js
@@ -249,8 +249,7 @@ Object.defineProperties(ModelAnimation.prototype, {
  * @returns {Number} Returns the local animation time.
  *
  * @example
- * // Use real time for model animation (also set
- * // ModelAnimationCollection#animateWhilePaused)
+ * // Use real time for model animation (assuming animateWhilePaused was set to true)
  * function animationTime(duration) {
  *     return Date.now() / 1000 / duration;
  * }
@@ -259,7 +258,7 @@ Object.defineProperties(ModelAnimation.prototype, {
  * // Offset the phase of the animation, so it starts halfway
  * // through its cycle.
  * function animationTime(duration, seconds) {
- *     return seconds / duration + .5;
+ *     return seconds / duration + 0.5;
  * }
  */
 export default ModelAnimation;
diff --git a/Source/Scene/ModelAnimationCollection.js b/Source/Scene/ModelAnimationCollection.js
@@ -447,7 +447,9 @@ ModelAnimationCollection.prototype.update = function (frameState) {
         scheduledAnimation._state === ModelAnimationState.STOPPED;
       // no change to delta, and no change to the animation state means we can
       // skip the update this time around.
-      if (play !== animationStopped) continue;
+      if (play !== animationStopped) {
+         continue;
+      }
     }
     scheduledAnimation._prevAnimationDelta = delta;
 

diff --git a/Source/Scene/ModelExperimental/ModelExperimentalAnimation.js b/Source/Scene/ModelExperimental/ModelExperimentalAnimation.js
@@ -400,8 +400,7 @@ ModelExperimentalAnimation.prototype.animate = function (time) {
  * @returns {Number} Returns the local animation time.
  *
  * @example
- * // Use real time for model animation (also set
- * // ModelExperimentalAnimationCollection#animateWhilePaused)
+ * // Use real time for model animation (assuming animateWhilePaused was set to true)
  * function animationTime(duration) {
  *     return Date.now() / 1000 / duration;
  * }
@@ -410,7 +409,7 @@ ModelExperimentalAnimation.prototype.animate = function (time) {
  * // Offset the phase of the animation, so it starts halfway
  * // through its cycle.
  * function animationTime(duration, seconds) {
- *     return seconds / duration + .5;
+ *     return seconds / duration + 0.5;
  * }
  */
 export default ModelExperimentalAnimation;
diff --git a/Source/Scene/ModelExperimental/ModelExperimentalAnimationCollection.js b/Source/Scene/ModelExperimental/ModelExperimentalAnimationCollection.js
@@ -480,7 +480,9 @@ ModelExperimentalAnimationCollection.prototype.update = function (frameState) {
         runtimeAnimation._state === ModelAnimationState.STOPPED;
       // no change to delta, and no change to the animation state means we can
       // skip the update this time around.
-      if (play !== animationStopped) continue;
+      if (play !== animationStopped) {
+          continue;
+      }
     }
     runtimeAnimation._prevAnimationDelta = delta;