You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is closely related to #10015 and #9884 but this has a few details that don't fully fit in either issue.
Suppose you have a tileset with 3DTILES_metadata, 3DTILES_content_gltf, but the glTF files do not use EXT_mesh_features.
Right now, no property tables will be created, so getFeature() would return undefined. When used in styling, any feature properties will result in undefined values which can cause problems like in this this local sandcastle (requires data from https://github.com/CesiumGS/3d-tiles-samples).
Not entirely sure if this is the right fix, but I think this requires:
Even if there are no feature tables, an empty one should be created. Not sure if this should be a ModelFeatureTable with length 0, or perhaps create a new class EmptyFeatureTable. This idea of "empty" feature tables seems similar to Model EXT_mesh_features: handle feature IDs without a property table #9884, except instead of representing an arbitrary number of features without metadata, this is a table that represents no features. It would be good to consider both at once.
This is closely related to #10015 and #9884 but this has a few details that don't fully fit in either issue.
Suppose you have a tileset with 3DTILES_metadata, 3DTILES_content_gltf, but the glTF files do not use
EXT_mesh_features
.Right now, no property tables will be created, so
getFeature()
would return undefined. When used in styling, any feature properties will result inundefined
values which can cause problems like in this this local sandcastle (requires data from https://github.com/CesiumGS/3d-tiles-samples).Not entirely sure if this is the right fix, but I think this requires:
ModelFeatureTable
with length 0, or perhaps create a new classEmptyFeatureTable
. This idea of "empty" feature tables seems similar toModel
EXT_mesh_features: handle feature IDs without a property table #9884, except instead of representing an arbitrary number of features without metadata, this is a table that represents no features. It would be good to consider both at once.XxxFeature
that represents the whole model, and has agetProperty()
that will look for tileset metadata (essentially Streamline the API for accessing tileset/tile metadata when picking #10015).The text was updated successfully, but these errors were encountered: