Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100 failing tests in latest Chrome #1047

Closed
mramato opened this issue Aug 21, 2013 · 4 comments
Closed

100 failing tests in latest Chrome #1047

mramato opened this issue Aug 21, 2013 · 4 comments

Comments

@mramato
Copy link
Contributor

mramato commented Aug 21, 2013

Yesterday, Chrome released 29.0.1547.57 on all platforms and Cesium has 100 failing tests using it. The first failure is Renderer/AutomaticUniforms can declare automatic uniforms. 90 of the failures are at the Renderer level, with the rest in Scene.

This may be related to #1002, because I see some matrix failures as well.

Thankfully, Viewer and the few Sandcastle examples I tried seem to work; but we should still investigate this and get it fixed ASAP since god knows what else is broken (and we can't validate new code if the tests all fail).

CC @pjcozzi @bagnell @emackey

@pjcozzi
Copy link
Contributor

pjcozzi commented Aug 21, 2013

Bummer. We'll look at it now.

@pjcozzi
Copy link
Contributor

pjcozzi commented Aug 21, 2013

With the same version of Chrome, these aren't on Mac, but there are a few other failures that we'll look at. See #1048

I can reproduce these on Windows and will continue looking.

@pjcozzi
Copy link
Contributor

pjcozzi commented Aug 21, 2013

I figured out at least some of the failures. The automatic uniforms are not being optimized out, which is crazy to me. #1031 will fix it (CC @gbeatty), but I'll put something smaller in now.

@mramato
Copy link
Contributor Author

mramato commented Aug 21, 2013

This release of Chrome may include a newly upgraded ANGLE, (I'm not sure if it was scheduled for 29 or 30), maybe there's a regression with it. On a side note, they are also going to switch from a DX9 backend to DX11 in Chrome 30 or 31, so that will be interesting to see as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants