Fix test failures in Chrome #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if this will help out the IE11 work that @kring was doing as well. Didn't that have the same issue of not optimizing out uniforms? |
|
I can confirm that all tests pass on Firefox and Chrome and all of the Sandcastle examples work (except for the ones you already filed issues for and #1054 which I just filed; all unrelated). I'm building CesiumViewer now just to make sure the built version still works and then I'll merge this (unless anyone else wants to take a look). |
|
App and doc builds work. |
Yes, it will help. This is not the end-game though since this includes all constants and structs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1002 (and #1047, but there are separate issues for unrelated failures on Mac and AMD).
This fix was tested in Chrome and Firefox and in release and debug. I also went through all the Sandcastle examples.
This fix is part of #1031 (CC @gbeatty), but is incomplete since we are still researching what will be done offline vs. at runtime. So this is not as fast or robust as the final shader pipeline will be, and it temporarily does not allow explicitly declaring automatic uniforms, which no one does anyway.