Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors thrown from Clock.onTick are not caught #2095

Closed
shunter opened this issue Aug 28, 2014 · 0 comments · Fixed by #2154
Closed

Errors thrown from Clock.onTick are not caught #2095

shunter opened this issue Aug 28, 2014 · 0 comments · Fixed by #2154

Comments

@shunter
Copy link
Contributor

shunter commented Aug 28, 2014

This is a regression introduced in #1674 . If an error occurs in a listener to Clock.onTick, the error panel is not displayed.

Sandcastle to reproduce:

var viewer = new Cesium.Viewer('cesiumContainer');

    var builtInCzml = 
[
  {
    "id":"document",
    "version":"1.0"
  },
  {
    "ellipse":{
      "outlineColor":{
        "rgba":[
          123,67,0,255
        ]
      },
      "semiMajorAxis":3000,
      "semiMinorAxis":4000,
      "height":3000
    },
    "position":{
      "cartographicDegrees":[
        -117.2,32.69,3000
      ]
    }
  }
];

    var czmlDataSource = new Cesium.CzmlDataSource();
    czmlDataSource.load(builtInCzml, 'Built-in CZML');
    viewer.dataSources.add(czmlDataSource);
@shunter shunter added the bug label Aug 28, 2014
mramato added a commit that referenced this issue Sep 24, 2014
Fix #2095 by making sure that exceptions generated by onTick callbacks are handled by the widget.
Remove superflous messaging from errors that are most likely not WebGL related.
abwood pushed a commit to abwood/cesium that referenced this issue Nov 18, 2014
Fix CesiumGS#2095 by making sure that exceptions generated by onTick callbacks are handled by the widget.
Remove superflous messaging from errors that are most likely not WebGL related.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant