Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute moon position #337

Closed
pjcozzi opened this issue Nov 20, 2012 · 1 comment
Closed

Compute moon position #337

pjcozzi opened this issue Nov 20, 2012 · 1 comment
Labels
cleanup type - enhancement

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 20, 2012

The czm_moonDirectionEC GLSL uniform is not the real vector to the moon. It is just something plausible for lighting. We should compute something more precise, and probably also revisit our sun computation.
@pjcozzi pjcozzi mentioned this issue Dec 17, 2012
Closed
@hpinkos hpinkos mentioned this issue Apr 22, 2013
Merged
@mramato
Copy link
Contributor

mramato commented Apr 22, 2013

Fixed in above pull.

@mramato mramato closed this as completed Apr 22, 2013
pjcozzi added a commit that referenced this issue Aug 9, 2015
@pjcozzi
Merge pull request #337 from AnalyticalGraphicsInc/buildings-error-ha…
c869316 
…ndling

Added rejection of promise on failed load.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup type - enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjcozzi @mramato