Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clamped billboards can shake #4736

Open
emackey opened this issue Dec 8, 2016 · 3 comments
Open

Clamped billboards can shake #4736

emackey opened this issue Dec 8, 2016 · 3 comments
Labels
category - billboards type - bug

Comments

@emackey
Copy link
Contributor

emackey commented Dec 8, 2016

Noticed during review of #4715, clamped billboards, label glyphs, and point primitives can have a 1-pixel horizontal shake when rotating the camera. This can be seen by loading the Ground Clamping Sandcastle demo, especially by setting a dark label background:

ok

It looks like maybe the horizontal position is being rounded incorrectly, allowing rounding errors to shake by a whole pixel.
@mramato
Copy link
Contributor

mramato commented Dec 8, 2016

Maybe the same bug as #4049?

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 2, 2017

Maybe the same bug as #4049?

Probably. @emackey do you agree?

@emackey
Copy link
Contributor Author

emackey commented Jan 2, 2017

Could be, but #4049 seems to require animating, and this bug happens while paused.

@emackey emackey mentioned this issue Jan 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category - billboards type - bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pjcozzi @emackey @mramato