Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandcastle Polyline example throw exception in Columbus view #499

Closed
pjcozzi opened this issue Feb 1, 2013 · 5 comments · Fixed by #502
Closed

Sandcastle Polyline example throw exception in Columbus view #499

pjcozzi opened this issue Feb 1, 2013 · 5 comments · Fixed by #502
Assignees

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 1, 2013

@bagnell this is all you...

Open http://localhost:8080/Apps/Sandcastle/index.html?src=Polylines.html

Switch to Columbus view. You'll get

Uncaught TypeError: Cannot read property 'longitude' of undefined

The polyline is passing Cartesian points to a function that wants cartographic. An an aside, we can probably change this function to work in Cartesian space, like I started to do for polygons that cross the IDL.

We should address this soon, but it will not hold up b13 since it is already in b12a (and I suspect others).

@ghost ghost assigned bagnell Feb 1, 2013
@mramato
Copy link
Contributor

mramato commented Feb 1, 2013

I disagree. We shouldn't ship a release with known broken Sandcastle examples.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Feb 1, 2013

We already did - several times - perhaps even including releases you did. I just tested carefully enough to find it - others did not. No one reported it in the wild; it is minor. We are releasing.

@mramato
Copy link
Contributor

mramato commented Feb 1, 2013

Just because we already did something doesn't mean it's necessarily okay to do it again. But you're the release-meister this month, so it's your judgment call.

@emackey
Copy link
Contributor

emackey commented Feb 1, 2013

@bagnell Beware of #497 which has a lot of Sandcastle changes coming in.

@bagnell bagnell mentioned this issue Feb 2, 2013
@bagnell
Copy link
Contributor

bagnell commented Feb 4, 2013

This is fixed in the above pull. Closing.

@bagnell bagnell closed this as completed Feb 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants