Wrap Longitude #502
Merged
Wrap Longitude #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d IntersectionTests.lineSegmentPlane method.
| @@ -20,10 +20,12 @@ Beta Releases | |||
| * Added `Transforms.computeIcrfToFixedMatrix` and `computeFixedToIcrfMatrix`. | |||
| * Added `EarthOrientationParameters`, `EarthOrientationParametersSample`, `Iau2006XysData`, and `Iau2006XysDataSample` classes to `Core`. | |||
| * CZML now supports the ability to specify positions in the International Celestial Reference Frame (ICRF), and inertial reference frame. | |||
| * Added a line segment-ray intersection test to `IntersectionTests`. | |||
| @@ -361,8 +361,8 @@ define([ | |||
| return positions; | |||
| }; | |||
|
|
|||
| Polyline.prototype._createSegments = function(ellipsoid) { | |||
| return PolylinePipeline.wrapLongitude(ellipsoid, this.getPositions()); | |||
| Polyline.prototype._createSegments = function(modelMatrix) { | |||
There was a problem hiding this comment.
This function is only one line now. Do we still need it? Actually, the whole segment management in PolylineCollection.js could use some work. However, we can hold off if we think there are bigger changes to come with the material improvements.
There was a problem hiding this comment.
I think we should wait until we start the material improvements.
|
@pjcozzi This is ready for another review. |
|
@mramato the code is good with me. Do you want to test and merge? |
|
Looks good, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #499 and #474.
PolylinePipeline.wrapLongitudenow takes a model matrix into account when computing line segments of a polyline that intersects the IDL.IntersectionTest.lineSegmentPlanemethod.