Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geocoder relies on pragma error #7158

Closed
pkuwwt opened this issue Oct 16, 2018 · 1 comment
Closed

Geocoder relies on pragma error #7158

pkuwwt opened this issue Oct 16, 2018 · 1 comment

Comments

@pkuwwt
Copy link

pkuwwt commented Oct 16, 2018

The Geocoder.flyToDestionation accept either a coordinate or a rect region.

However, it distinguishes between them by a DevelopError from the pragma in Cartesian3.normalize.

So if you remove all the pragma block in code, then there will be a problem. Geocoder will use the wrongly normalized coordinate other than another option: rect.

I noticed that the official build just removes the pragma comment other than the whole code block.

So I guess the DevelopError statement should be moved out of the pragma block to avoid misunderstanding.

@hpinkos
Copy link
Contributor

hpinkos commented Oct 16, 2018

Hi @pkuwwt, I believe we just fixed this today: #7154

The fix will be included in the 1.51 release available on November 1st. If this is a different issue, let me know and I can reopen this issue. Thanks!

@hpinkos hpinkos closed this as completed Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants