Make computeFlyToLocationForRectangle always return a Cartographic #7154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what I was thinking when I wrote `computeFlyToLocationForRectangle`, but this changes it so it always returns a `Cartographic`. Previously it would return a Rectangle if terrain wasn't set or didn't have `availability` which just made the calling code confusing for no reason and lead to #7143. `computeFlyToLocationForRectangle` is private, so this isn't a breaking change. Fixes #7143
|
Thanks for the pull request @mramato!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
|
👍 thanks @mramato! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what I was thinking when I wrote
computeFlyToLocationForRectangle, but this changes it so it always returns aCartographic. Previously it would return a Rectangle if terrain wasn't set or didn't haveavailabilitywhich just made the calling code confusing for no reason and lead to #7143.computeFlyToLocationForRectangleis private, so this isn't a breaking change.Fixes #7143