Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighting issues with glTF rendering #7800

Closed
mramato opened this issue May 1, 2019 · 4 comments
Closed

Lighting issues with glTF rendering #7800

mramato opened this issue May 1, 2019 · 4 comments

Comments

@mramato
Copy link
Contributor

mramato commented May 1, 2019

Check out the Milk Truck and Draco Compressed Model options in our 3D Models demo:

https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/?src=3D%20Models.html

The Milk Truck seems overly dark no matter what time of day it is, this is the brightest I could get it, but maybe this is correct?

image

Meanwhile, the Draco compressed version of the same model is super washed out:

image

I also just noticed the "fuzzy" Cesium logo on the hood.

Why do these two models look so different?

@lilleyse or @likangning93 any thoughts here?

@lilleyse
Copy link
Contributor

lilleyse commented May 1, 2019

The first is glTF 1, so we can't really do much about the lighting except to upgrade our sample models to glTF 2, and the second is glTF 2 / PBR and IBL seems too strong.

@mramato
Copy link
Contributor Author

mramato commented May 1, 2019

I actually just wrote up #7802 before you made this comment. We need to put our best foot forward and to me that means glTF 2.0.

@lilleyse
Copy link
Contributor

lilleyse commented May 1, 2019

Opened #7803 for making the lighting look better.

@mramato
Copy link
Contributor Author

mramato commented Aug 16, 2019

This has 2 more specific issues to deal with the problem described above.

@mramato mramato closed this as completed Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants