Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all SampleData models to gltf 2.0 #7802

Closed
mramato opened this issue May 1, 2019 · 2 comments · Fixed by #8539
Closed

Upgrade all SampleData models to gltf 2.0 #7802

mramato opened this issue May 1, 2019 · 2 comments · Fixed by #8539
Labels

Comments

@mramato
Copy link
Contributor

mramato commented May 1, 2019

Looks like there are several glTF 1.0 models still being shipped with Cesium, since almost no one else supports glTF 1.0, we should make sure everything we ship uses 2.0. We probably also want to revisit how many different versins of some models we have and perhaps more cleanly label some of the files/folders.

Might be a good idea to make everything glb as well. This is sample data, not test data so we should treat it like we were shipping production-ready models.

@lilleyse
Copy link
Contributor

lilleyse commented Jan 13, 2020

@sanjeetsuhag for testing...

  • Verify that all Sandcastle examples that use these models still look correct after the models are switched over to glTF 2.0. This includes the Shadows demo in the Development folder.
  • Verify that all sample models, including ones that are already 2.0, pass the glTF validator.
  • Make sure that unit tests pass. You can either run npm run test or go to http://localhost:8080/ and click Run all tests [EDIT: models in sample data folder shouldn't actually affect tests, but still good to do for practice]

@lilleyse
Copy link
Contributor

lilleyse commented Jan 13, 2020

Also...

  • Remove CesiumMilkTruck-kmc.glb. Any Sandcastle examples that use that can use the regular glTF 2.0 CesiumMilkTruck.glb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants