Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts in classification example in 1.70? #8953

Closed
OmarShehata opened this issue Jun 12, 2020 · 7 comments · Fixed by #9108
Closed

Artifacts in classification example in 1.70? #8953

OmarShehata opened this issue Jun 12, 2020 · 7 comments · Fixed by #9108

Comments

@OmarShehata
Copy link
Contributor

This was reported over email - the classification example (https://sandcastle.cesium.com/index.html?src=3D%20Tiles%20Photogrammetry%20Classification.html) has these artifacts, almost as if the the classification tileset is being clipped too early by the near plane, only on mobile (Android or iOS).

I put together an example on Glitch to make it easier to test on mobile (you can fork it and change the CesiumJS include to 1.69 to see that it works there, and the artifacts are only present in 1.70.

https://glitch.com/edit/#!/classification-cesium-error?path=index.html%3A5%3A68

1.70

Screenshot_20200612-122848

1.69

Screenshot_20200612-122903

@OmarShehata
Copy link
Contributor Author

I don't see an obvious place to start looking as the cause of this break in the CHANGES for 1.70, any advice @lilleyse ?

@IanLilleyT
Copy link
Contributor

Either #8854 or #8870

@OmarShehata
Copy link
Contributor Author

Git bisect confirms this is the commit that introduced this issue: 2da52de

@OmarShehata
Copy link
Contributor Author

Marking as priority next release since it's a regression that's breaking some people's applications.

@IanLilleyT
Copy link
Contributor

If we figure out why this regression happened, it might help us understand non-3D Tiles classification bugs on mobile. Last time I looked I didn't have any leads, but I'll look some more soon.

@IanLilleyT
Copy link
Contributor

Haven't had a chance to look into this enough, so it should be pushed to the next release (again). It's looking like a multi-frustum problem though.

@lilleyse lilleyse mentioned this issue Aug 4, 2020
5 tasks
@lilleyse
Copy link
Contributor

lilleyse commented Aug 4, 2020

git bisect points to 2da52de

It's a multi-frustum problem that can be triggered by disabling log depth.

Local sandcastle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants