Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PointCloud.js should not call CesiumMath.setRandomNumberSeed #9730

Closed
mramato opened this issue Aug 14, 2021 · 0 comments · Fixed by #9978
Closed

PointCloud.js should not call CesiumMath.setRandomNumberSeed #9730

mramato opened this issue Aug 14, 2021 · 0 comments · Fixed by #9978

Comments

@mramato
Copy link
Contributor

mramato commented Aug 14, 2021

CesiumMath.setRandomNumberSeed is meant to be called by user (and test) code only because it sets a global RNG seed. It looks like PointCloud.js call it in getRandomValues. Why?

It should be removed. If a repeatable RNG is needed, it should create its own instance of MersenneTwister.

Stumbled on this while addressing random CI failures in #9729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.pnts loader for ModelExperimental CesiumGS/cesium
1 participant
@mramato