-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.pnts loader for ModelExperimental #9978
Conversation
Thanks for the pull request @ptrgags!
Reviewers, don't forget to make sure that:
|
Most of the way done, though still need to figure out why the time dynamic point cloud tests are failing (it renders, but then after the Oh right, I remember at one point turning on the bounding sphere draw commands and one model was showing up incorrectly. I'll add that to the checklist above. |
I talked with @lilleyse about the sRGB handling a bit so now I have a better understanding of what the goal here is. To summarize:
Other notes:
|
Fixed the sRGB handling, but I'm noticing a few aditional things after playing with an updated Sandcastle
|
For |
Still investigating the crash when I try to apply a style. So far what I see happening:
|
I figured out the crash - I overlooked that the vertex attribute buffers need to be marked as "not destroyable" so they don't get double destroyed when the style changes. Now I'm noticing: |
Turns out it wasn't that, there was a syntax error in the style that was being swallowed PointCloudBatched now renders correctly (the difference in color is due to PBR vs Lambert shading) Per-point properties will not work, but that falls under #9944. @lilleyse at this point this PR is ready for review again! |
Thanks @ptrgags. I tested HDR on/off and spot checked some other sandcastles. glTF point clouds work fine as well. |
Fixes #9730
Similar to #9968, this PR adds support for loading point clouds with ModelExperimental, each part of #9836
This one was more involved, as pnts does not contain a glTF. Instead, the
PntsLoader
generates aModelComponents
object (our new runtime data structure for representing a 3D model) with aPOINTS
primitive.This PR Does NOT cover the following. These will be future PRs:
This PR is most of the way there, but the following things need to be updated:
PointCloud3DTIleContent
TimeDynamicPointCloud
PntsLoader
PntsParser