Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in GltfLoader for handling Draco _BATCHID #10031

Merged
merged 3 commits into from
Jan 24, 2022

Conversation

ptrgags
Copy link
Contributor

@ptrgags ptrgags commented Jan 24, 2022

While working on #10018, I noticed that this Sandcastle was failing to load draco tiles.

I tracked it down, it was a regression in #10008. Only the ModelComponents.Attribute.semantic should be renamed, not the semantic for the vertex buffer loader.

@lilleyse could you review?

@ptrgags ptrgags requested a review from lilleyse January 24, 2022 17:49
@cesium-concierge
Copy link

Thanks for the pull request @ptrgags!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@lilleyse lilleyse merged commit 8646364 into main Jan 24, 2022
@lilleyse lilleyse deleted the fix-batch-id-rename branch January 24, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants