Add ModelAnimation.startOffset

[srcejon]

As per #10042, this PR adds ModelAnimation.startOffset, which allows specifying at what point an animation starts playing from.

[cesium-concierge]

Thanks for the pull request @srcejon!

• ✔️ Signed CLA found.
• ❔ CHANGES.md was not updated.
  • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
• ❔ Unit tests were not updated.
  • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

• Cesium Viewer works.
• Works in 2D/CV.

[cesium-concierge]

Thanks again for your contribution @srcejon!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

[markw65]

This seems like the wrong place to be adding startDelta.

What happens when loop is set to REPEAT for example? Or worse, MIRRORED_REPEAT.

It also seems to be in the wrong units. If its supposed to be a "Fractional offset in to the animation's timeline" shouldn't it be multiplied by duration? By doing it this way, the user has to know what the duration is.

I think the best way to fix this is to add startDelta to delta on line 415. Then startDelta really can be a fraction, and REPEAT, MIRRORED_REPEAT will be properly handled, and play will be correctly handled when repeat is false...

[cesium-concierge]

Thanks again for your contribution @srcejon!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

[cesium-concierge]

Thanks again for your contribution @srcejon!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

[markw65]

I think that (in addition to needing fixes to make it work properly, as I mentioned above) this can be trivially handled using ModelAnimation.animationTime as provided by #9339, so is no longer needed.

[cesium-concierge]

Thanks again for your contribution @srcejon!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

[cesium-concierge]

Thanks again for your contribution @srcejon!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

[cesium-concierge]

Thanks again for your contribution @srcejon!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

[ggetz]

I'm closing this due to inactivity. If you believe this is still an issue, please feel free to re-open and we'll give this a fresh review. Thanks!