Added a post processing stage for atmosphere light scattering #10063

xtassin · 2022-02-02T10:40:49Z

Also added a Sandcastle example for this new post processing stage

cesium-concierge · 2022-02-02T10:40:53Z

Thanks for the pull request @xtassin!

✔️ Signed CLA found.
❔ CHANGES.md was not updated.
- If this change updates the public API in any way, please add a bullet point to CHANGES.md.
❔ Unit tests were not updated.
- Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

Cesium Viewer works.
Works in 2D/CV.

…then fails with <code>39:9 error Parsing error: The keyword 'let' is reserved</code>

…tmospherePostProcessing

…nColor variable in AtmospherePostProcessing.html is clearly a variable and is reassigned in the call to the Color.lerp method. Eslint insist on making it a const but I, as a human being, disagree, even though I am forced to comply to make the build work.

ggetz · 2022-02-02T13:55:30Z

Thanks @xtassin! This looks great! @sanjeetsuhag Would you be able to do a review?

Apps/Sandcastle/gallery/AtmospherePostProcessing.html

sanjeetsuhag

Thanks for the contribution, @xtassin. The effect in the Sandcastle looks amazing! I have a few comments: mostly around the documentation and the public API side of things.

Apps/Sandcastle/gallery/AtmospherePostProcessing.html

Source/Scene/PostProcessStageLibrary.js

Source/Shaders/PostProcessStages/AtmosphericScattering.glsl

Source/Scene/PostProcessStageLibrary.js

Apps/Sandcastle/gallery/AtmospherePostProcessing.html

Co-authored-by: Sam Suhag <sanjeetsuhag@users.noreply.github.com>

… fixed value.

…tmospherePostProcessing

Co-authored-by: Sam Suhag <sanjeetsuhag@users.noreply.github.com>

… fixed value.

…tmospherePostProcessing

…ge only.

Co-authored-by: Gabby Getz <gabby@cesium.com>

sanjeetsuhag · 2022-02-18T15:37:22Z

I've pushed a pretty significant refactor to this PR - incorporating the concepts from the papers mentioned in the source here into our own SkyAtmosphere and GroundAtmosphere shaders. The SkyAtmosphere is looking better, but the GroundAtmosphere might need some more fine tuning to look correct and clear.

Here's a running list of tasks remaining:

Fix SkyAtmosphere translucency.
Fix fog calculation in GlobeFS
Fix phase function calculation in vertex shader
Expose LIGHT_INTENSITY to the public API
Investigate why using the value passed in u_radiiAndDynamicAtmosphereColor causes issues with SkyAtmosphere
Verify all types of dynamic lighting are still working
Add references to papers
Investigate polar region sky lighting issues

…ing paper

lilleyse · 2022-04-21T21:46:49Z

Nice that fixed it for me.

That's all the feedback I have on the visuals. @IanLilleyT can you do a final code review by early next week?

sanjeetsuhag · 2022-04-22T15:46:01Z

@IanLilleyT Since I'll be out next week, is there a chance you could take a look at this today? It would be great to get this in this release.

lilleyse · 2022-04-22T17:34:55Z

@sanjeetsuhag Ian is out today but I can take a look

Apps/Sandcastle/gallery/Atmosphere.html

lilleyse · 2022-04-22T19:50:20Z

I maybe could've dived deeper into the math, but the code looks very clean and well organized. Fog culling is slightly more pronounced because the fog is darker than before, but I don't see a reason to hold this up any longer. The visuals have turned out really nice here.

lilleyse · 2022-04-22T19:54:35Z

Just wanted to capture a nice screenshot to celebrate this getting merged.

lilleyse · 2022-04-22T19:57:39Z

Could you update CHANGES.md as well?

…tles

…herePostProcessing

ggetz · 2022-04-22T21:13:19Z

@sanjeetsuhag Can we swap the dropdown out for two buttons ("Sky Atmosphere" and "Ground Atmosphere") that work like tabs? The dropdown to switch screens is not a typical UI pattern.

sanjeetsuhag · 2022-04-22T21:30:37Z

@ggetz I added a tabbed view

ggetz · 2022-04-22T23:29:28Z

Great, thanks @sanjeetsuhag! I'm happy to merge as long as @lilleyse is satisfied.

lilleyse · 2022-04-25T13:57:18Z

@ggetz all good from my side so I merged. Thanks @xtassin and @sanjeetsuhag.

xtassin · 2022-05-05T06:36:38Z

Could you please mention @sanjeetsuhag instead of me on the release page https://cesium.com/blog/2022/05/02/cesium-releases-in-may-2022/

I don't believe I deserve any credit for this PR.

Thanks.

Added a post processing stage for atmosphere light scattering

d832071

Also added a Sandcastle example for this new post processing stage

xtassin added 4 commits February 2, 2022 11:42

Merge branch 'main' into AtmospherePostProcessing

a419d58

Replaced var with let to fix broken build. As a note, my local build …

7988b80

…then fails with <code>39:9 error Parsing error: The keyword 'let' is reserved</code>

Merge remote-tracking branch 'origin/AtmospherePostProcessing' into A…

3f8c64c

…tmospherePostProcessing

ggetz assigned sanjeetsuhag Feb 2, 2022

ggetz reviewed Feb 2, 2022

View reviewed changes

Apps/Sandcastle/gallery/AtmospherePostProcessing.html Outdated Show resolved Hide resolved

sanjeetsuhag reviewed Feb 2, 2022

View reviewed changes

xtassin and others added 12 commits February 3, 2022 08:07

Update Apps/Sandcastle/gallery/AtmospherePostProcessing.html

2cbb9d7

Co-authored-by: Sam Suhag <sanjeetsuhag@users.noreply.github.com>

Update Apps/Sandcastle/gallery/AtmospherePostProcessing.html

5d59b67

Co-authored-by: Sam Suhag <sanjeetsuhag@users.noreply.github.com>

Update Source/Scene/PostProcessStageLibrary.js

3b3a1a3

Co-authored-by: Sam Suhag <sanjeetsuhag@users.noreply.github.com>

Use Cesium.Ellipsoid.WGS84 to extract minimum earth radius instead of…

d3a8507

… fixed value.

Merge remote-tracking branch 'origin/AtmospherePostProcessing' into A…

2d1ccbd

…tmospherePostProcessing

Update Source/Scene/PostProcessStageLibrary.js

60c273b

Co-authored-by: Sam Suhag <sanjeetsuhag@users.noreply.github.com>

Update Source/Scene/PostProcessStageLibrary.js

d8ed42f

Co-authored-by: Sam Suhag <sanjeetsuhag@users.noreply.github.com>

Use Cesium.Ellipsoid.WGS84 to extract minimum earth radius instead of…

e6edce8

… fixed value.

Merge remote-tracking branch 'origin/AtmospherePostProcessing' into A…

5105a10

…tmospherePostProcessing

Removed optional rendering effect to focus on the post processing sta…

8b24499

…ge only.

Update Apps/Sandcastle/gallery/AtmospherePostProcessing.html

0574bca

Co-authored-by: Gabby Getz <gabby@cesium.com>

Refactor into SkyAtmosphere and GroundAtmosphere

5aefbc4

sanjeetsuhag and others added 7 commits March 4, 2022 14:27

New version

9fc97e4

Fixes atmosphere radius, intersection test

ec9f928

Fixes radiiAndDynamicAtmosphereColor

340f5b5

Uses the Rayleigh color constants from Precomputed Atmosphere Scatter…

a44740c

…ing paper

Inverted opacity to show atmosphere color in sky atmosphere

4fae116

Fix tonemapping, HSB bug CesiumGS#1

5e3ea35

Remove unused shader, adjust atmosphere intensity for GlobeFS

2dc72f3

sanjeetsuhag added 2 commits April 21, 2022 15:32

Documentation fix

2e5bad0

Clean up pass

34f73c3

sanjeetsuhag added 3 commits April 22, 2022 11:06

Improves documentation

e157cf5

Fix inconsistency in fragment shader light source for sky atmosphere

7ed519c

Added toggle for SkyAtmosphere in Sandcastle

ca261e5

lilleyse reviewed Apr 22, 2022

View reviewed changes

Apps/Sandcastle/gallery/Atmosphere.html Show resolved Hide resolved

sanjeetsuhag and others added 5 commits April 22, 2022 16:56

Combines Atmopshere Sandcastle with Ground and Sky Atmosphere Sandcas…

ac3408f

…tles

Removes Ground Atmosphere and Sky Atmosphere Sandcastles

88ef353

Merge branch 'main' of https://github.com/CesiumGS/cesium into Atmosp…

8c0955f

…herePostProcessing

Added entry in CHANGES.md

f5b5beb

Remove old links [skip ci]

47d1d86

Add tabbed view for Atmosphere sandcastle

e5d8196

lilleyse merged commit 4a37d34 into CesiumGS:main Apr 25, 2022

ggetz mentioned this pull request Apr 27, 2022

requestWebgl2 Bug Cesium 1.92 #10329

Closed

cmcleese mentioned this pull request Jul 5, 2022

Big performance drop from v1.93 onward #10510

Closed

jjhembd mentioned this pull request Apr 13, 2023

Sky atmosphere gets brighter when the sun is offscreen in HDR mode #8718

Closed

ggetz mentioned this pull request Jun 30, 2023

Unable to display image layers on mobile devices #11289

Open

nf-s mentioned this pull request Feb 6, 2024

TerriaJS release 8.5.0 - Cesium upgrade TerriaJS/terriajs#7027

Closed

3 tasks

askmyselfwhy mentioned this pull request Apr 25, 2024

Orthographic camera projection #11955

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a post processing stage for atmosphere light scattering #10063

Added a post processing stage for atmosphere light scattering #10063

xtassin commented Feb 2, 2022

cesium-concierge commented Feb 2, 2022

ggetz commented Feb 2, 2022 •

edited

Loading

sanjeetsuhag left a comment

sanjeetsuhag commented Feb 18, 2022 •

edited

Loading

lilleyse commented Apr 21, 2022

sanjeetsuhag commented Apr 22, 2022

lilleyse commented Apr 22, 2022

lilleyse commented Apr 22, 2022

lilleyse commented Apr 22, 2022

lilleyse commented Apr 22, 2022

ggetz commented Apr 22, 2022

sanjeetsuhag commented Apr 22, 2022

ggetz commented Apr 22, 2022

lilleyse commented Apr 25, 2022

xtassin commented May 5, 2022

Added a post processing stage for atmosphere light scattering #10063

Added a post processing stage for atmosphere light scattering #10063

Conversation

xtassin commented Feb 2, 2022

cesium-concierge commented Feb 2, 2022

ggetz commented Feb 2, 2022 • edited Loading

sanjeetsuhag left a comment

Choose a reason for hiding this comment

sanjeetsuhag commented Feb 18, 2022 • edited Loading

lilleyse commented Apr 21, 2022

sanjeetsuhag commented Apr 22, 2022

lilleyse commented Apr 22, 2022

lilleyse commented Apr 22, 2022

lilleyse commented Apr 22, 2022

lilleyse commented Apr 22, 2022

ggetz commented Apr 22, 2022

sanjeetsuhag commented Apr 22, 2022

ggetz commented Apr 22, 2022

lilleyse commented Apr 25, 2022

xtassin commented May 5, 2022

ggetz commented Feb 2, 2022 •

edited

Loading

sanjeetsuhag commented Feb 18, 2022 •

edited

Loading