-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for UINT8-based property textures in CustomShader
#10247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the pull request @ptrgags!
Reviewers, don't forget to make sure that:
|
Okay this is ready, @lilleyse could you review? |
lilleyse
reviewed
Mar 30, 2022
Could you add a new Sandcastle example based on https://demos.cesium.com/owt-uncertainty minus the picking functionality? |
@lilleyse added the sandcastle, this is ready for review again |
lilleyse
reviewed
Mar 31, 2022
@lilleyse updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes what #10073 started; it implements the basics of property textures (see the
EXT_structural_metadata
spec) inCustomShader
.Parsing metadata in the shader is rather involved due to type conversions and WebGL 1 limitations. So this PR only implements the following types which are the easiest to represent in texture form:
SCALAR
UINT8
(normalized) -- these becomefloat
in the shaderSCALAR
UINT8
-- these becomeint
in the shader since WebGL 1 doesn't supportuint
VEC2/3/4
UINT8
(normalized) -- these becomevec2/3/4
in the shader. These are parsed from multiple texture channels.VEC2/3/4
UINT8
-- these becomeivec2/3/4
in the shader. These are parsed from multiple texture channels.UINT8
(normalized and unnormalized) with 2-4 components -- these become the most appropriate vector type as described in the previous 2 bullets.Though the spec supports several more types (e.g. a
UINT16
spread across two texture channels), those will be handled in future PRs.Sandcastle for testing
To Do:
CHANGES.md
CustomShader
guideCustomShader
. Handle noData/default metadata values inCustomShader
#10249