Add enableDebugWireframe to use wireframes for ModelExperimental in WebGL1
#10344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @j9liu!
Reviewers, don't forget to make sure that:
|
IanLilleyT
suggested changes
May 3, 2022
| @@ -269,6 +267,7 @@ describe( | |||
|
|
|||
| afterAll(function () { | |||
| scene.destroyForSpecs(); | |||
| sceneWithWebgl2.destroyForSpecs(); | |||
| const useUint8Array = indicesBuffer.sizeInBytes === indicesCount; | ||
| originalIndices = useUint8Array | ||
| ? new Uint8Array(indicesCount) | ||
| : IndexDatatype.createTypedArray(vertexCount, indicesCount); |
There was a problem hiding this comment.
@lilleyse do you know why IndexDatatype.createTypedArray doesn't output 8-bit indices, and if there's any code that depends on it outputting 16/32 only? Or if there's any code that also has this workaround.
There was a problem hiding this comment.
For now, going to leave this code in, and address it in a future PR
|
I turned wireframe on and off (both before and after this PR) in WebGL1 in the Model Experimental 3D Model Sandcastle and the memory reduction is working as expected! New + No Wireframe:
New + Wireframe:
Old + No Wireframe:
Old + Wireframe:
|
IanLilleyT
approved these changes
May 4, 2022
|
Thanks @j9liu ! |
This was referenced Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10340. Currently wireframes in
ModelExperimentalrequire the indices to be loaded as typed arrays for WebGL1. However, this will result in performance costs for users that don't need thedebugWireframeoption.The preferred solution is to require an option,
enableDebugWireframe, to be explicitly set astruein theModelExperimentalconstructors. If this is true, thendebugWireframewill work for models in WebGL1. However, if this is not true, then togglingdebugWireframewill have no effect. This will not affect models in WebGL2 because in WebGL2, data can be pulled from GPU buffers.ModelExperimentalSandcastle and 3D Tiles sandcastle for testing. I left comments for the lines that should be toggled on / off for testing.