Remove error property from DeveloperError and RuntimeError. #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors can't be sent back from Web Workers. We can still capture the stack trace as a string and use that, without the error object.
|
@emackey since I believe you were the one that originally added this capability, do you have any concerns over this change? Looks solid to me and is for a good reason, but I just wanted to double check with you. |
|
Looks good to me. I think the stack trace is the main thing I was trying to get on mobile at the time. |
mramato
added a commit
that referenced
this pull request
Aug 19, 2013
…WebWorkers Remove error property from DeveloperError and RuntimeError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error objects can't be sent back from Web Workers. We still capture the stack trace as a string and keep that, without needing the error object.
This addresses the first of several problems that is causing #1039. This fix makes it so we can actually see the error that's causing the problem.