Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vector polyline clamping #10447

Merged
merged 3 commits into from
Jun 10, 2022
Merged

Fix vector polyline clamping #10447

merged 3 commits into from
Jun 10, 2022

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Jun 10, 2022

This fixes a regression from 6e5e7a0#diff-9c322fcbd2bf3549f60528f6659332e11465537ef57caefcc5bae56e7af3a356 which occurs when clamping a vector tileset.

We plan on releasing this as a patch release, so this is targeted for a 1.94.3-release branch. After this is merged and release, we will also merge it into main.

@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ggetz
Copy link
Contributor Author

ggetz commented Jun 10, 2022

Thanks @ephjos for verifying this fix!

@ggetz ggetz merged commit 0fcfb6b into 1.94.3-release Jun 10, 2022
@ggetz ggetz deleted the fix-clamping branch June 10, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants