-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Just in time" builds #10538
"Just in time" builds #10538
Conversation
Thanks for the pull request @ggetz!
Reviewers, don't forget to make sure that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggetz This is going to be a great quality of life update! I have a few initial comments.
@@ -48,15 +48,16 @@ | |||
"aws-sdk": "^2.932.0", | |||
"bitmap-sdf": "^1.0.3", | |||
"bluebird": "^3.7.2", | |||
"chokidar": "^3.5.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still got the following warning when running npm install
:
npm WARN deprecated chokidar@2.1.8: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
Looking at node_modules/chokidar/package.json
, the version
seems to indicate 3.5.3
, so I don't know what's causing this. Do you see this same output when running the install step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not due to our immediate chokidar
dependency. It's a fairly common package that others depend on as well.
You can run npm list --depth=[depth]
to check the dependency tree.
In this case it looks like gulp@4.0.2
is the source of this warning. That's still the latest version unfortunately. We'll need to weigh if we want to stay will gulp, which is still a popular tool despite the lack of updates. Irregardless, that would be out of the scope of this PR.
Co-authored-by: Sam Suhag <sanjeetsuhag@users.noreply.github.com>
That @sanjeetsuhag! I've responded to all of your feedback. |
@sanjeetsuhag Can you take another look at this when you get the chance now that #10399 is merged? |
Thanks @sanjeetsuhag! I addressed your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks @ggetz!
This is a followup from #10399
Refactors the build scripts a bit to allow for "just in time" compilation, a method we use in other projects for internal app development.
This allows a developer to run
without having to manually build, and everything should "just work".
This is done by revising
server.cjs
such that requests toCesium.js
or similar build artifacts will case rebuilding incrementally if a file has changed before serving the file contents.gulpfile.cjs
intobuild.cjs
HelloWorld
now uses unminified Cesium so it works during development builds without having to manually build.server.js
build.js
eslint errors