Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autolinker and jsep dependencies #10959

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Update autolinker and jsep dependencies #10959

merged 1 commit into from
Jan 2, 2023

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Dec 15, 2022

This updates the remaining outdated direct dependencies– jsep and autolinker. For both, there were slight tweaks to the APIs which were updated here.

Lerc is still an outstanding direct dependency update. The new version now requires using wasm. It looks like, despite the fact that the wasm file is built to support multiple ways of loading the module, the lerc API only allows one way to load wasm files and that way does not fit within our worker architecture, throwing errors when loading. I'll writeup a separate issue to cover it.

@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@sanjeetsuhag
Copy link
Contributor

Not exactly familiar with these dependencies and how they work, but the changes look fine to me on a surface level and the tests and Sandcastle for related files are working as expected.

Thanks @ggetz!

@sanjeetsuhag sanjeetsuhag merged commit 39f134f into main Jan 2, 2023
@sanjeetsuhag sanjeetsuhag deleted the update-packages branch January 2, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants