-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed color creation from CSS color string with modern "space-separated" syntax #11271
Fixed color creation from CSS color string with modern "space-separated" syntax #11271
Conversation
…SS colors with modern "space-separated" syntax
Thank you so much for the pull request @aerialist7! I noticed this is your first pull request and I wanted to say welcome to the Cesium community! The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.
Reviewers, don't forget to make sure that:
|
UPD: |
@ggetz, as I understand tests fail because of Node.js version |
Thanks for the PR @aerialist7! I am seeing some test failures in the CI logs - https://app.travis-ci.com/github/CesiumGS/cesium/jobs/601666466. I think there is an extra character in the regex string. |
@aerialist7 Once #11271 (comment) is resolved, could you please update |
…errain at that x, y, level
Co-authored-by: Jeshurun Hembd <jeshurun@cesium.com>
@ggetz, done. |
Color.fromCssColorString
parsing rgb(a)
/hsl(a)
CSS colors with modern "space-separated" syntax
Awesome, thanks again @aerialist7! |
Support
Color.fromCssColorString
parsingrgb(a)
/hsl(a)
CSS colors with modern "space-separated" syntaxCloses #11264