Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed color creation from CSS color string with modern "space-separated" syntax #11271

Merged
merged 28 commits into from
May 25, 2023
Merged

Fixed color creation from CSS color string with modern "space-separated" syntax #11271

merged 28 commits into from
May 25, 2023

Conversation

aerialist7
Copy link
Contributor

@aerialist7 aerialist7 commented May 7, 2023

Support Color.fromCssColorString parsing rgb(a)/hsl(a) CSS colors with modern "space-separated" syntax

Closes #11264

…SS colors with modern "space-separated" syntax
@cesium-concierge
Copy link

Thank you so much for the pull request @aerialist7! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@aerialist7
Copy link
Contributor Author

aerialist7 commented May 7, 2023

UPD:
✅ CONTRIBUTORS.md entry was updated
✅ CLA was confirmed
CHANGES.md was not updated because there were no API changes
✅ Unit tests were updated

@aerialist7
Copy link
Contributor Author

aerialist7 commented May 7, 2023

@ggetz, as I understand tests fail because of Node.js version

@ggetz
Copy link
Contributor

ggetz commented May 11, 2023

Thanks for the PR @aerialist7!

I am seeing some test failures in the CI logs - https://app.travis-ci.com/github/CesiumGS/cesium/jobs/601666466.

I think there is an extra character in the regex string.

@ggetz
Copy link
Contributor

ggetz commented May 18, 2023

@aerialist7 Once #11271 (comment) is resolved, could you please update CHANGES.md with a summary of your changes?

@aerialist7
Copy link
Contributor Author

aerialist7 commented May 25, 2023

@aerialist7 Once #11271 (comment) is resolved, could you please update CHANGES.md with a summary of your changes?

@ggetz, done.
Also, I moved my changes to a separate branch, so there are no conflicts anymore, you can easily merge it

@aerialist7 aerialist7 requested a review from ggetz May 25, 2023 06:18
@aerialist7 aerialist7 changed the title Support Color.fromCssColorString parsing rgb(a)/hsl(a) CSS colors with modern "space-separated" syntax Fixed color creation from CSS color string with modern "space-separated" syntax May 25, 2023
@ggetz
Copy link
Contributor

ggetz commented May 25, 2023

Awesome, thanks again @aerialist7!

@ggetz ggetz merged commit 2f409a4 into CesiumGS:main May 25, 2023
@aerialist7 aerialist7 deleted the space-separated-css-colors-support branch May 25, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to parse color from rgb/rgba CSS color string
6 participants