Fixed label background rendering.

[IKangXu]

If the initial label background color is set to false and then dynamically modified to true, rendering problems will occur.

Before repair

After repair

[cesium-concierge]

Thank you so much for the pull request @IKangXu! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

• ❌ Missing CONTRIBUTORS.md entry.
  • Please add yourself to the contributors file!
• ❌ Missing CLA.
  • Please send in a Contributor License Agreement (CLA) and comment back here to let us know to check this!
• ❔ CHANGES.md was not updated.
  • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
• ❔ Unit tests were not updated.
  • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

• Cesium Viewer works.
• Works in 2D/CV.

[ggetz]

Hi @IKangXu.

In order to review this PR, we will need the following:

• Submit a Contributor License Agreement (CLA) then comment back here to let us know
• Add yourself to the contributors file

Thanks!

[IKangXu]

Hi @IKangXu.

In order to review this PR, we will need the following:

• Submit a Contributor License Agreement (CLA) then comment back here to let us know
• Add yourself to the contributors file

Thanks!

✅ CONTRIBUTORS.md entry was updated
✅ CLA was confirmed
✅ CHANGES.md was updated

[IKangXu]

example

[IKangXu]

@ggetz

[ggetz]

Thanks @IKangXu! We will review shortly, with the intention of getting this into the next release.

[IKangXu]

@ggetz Thanks a lot.

[ggetz]

Hi @IKangXu, I can confirm this fixes the issue. However, I think there may be a fix that is a bit simpler.

I believe we can get the same effect with this code change. This would remove the need for the additional getSubRegionIndex function. What do you think?

Also, please resolve the conflicts in CHANGES.md when you can.

Thanks again!

[IKangXu]

Hi @ggetz, If getSubRegionIndex is deleted, it will require frequent waiting for imageIndexPromise, Actually, these have already been added to the atlas

As the annotation in the figure states.

CHANGES.md file conflict resolved.

[ggetz]

@IKangXu In the case where an image is already created, .addImage will return early with an existing promise if available rather than creating any new resources. This will take a frame to resolve, but ensures that any in-process additions do finish before continuing.

Can we do the same early return for addSubRegion instead of creating a whole new function? It keeps the API footprint smaller and simplifies the control flow in _loadImage.

[IKangXu]

@IKangXu In the case where an image is already created, .addImage will return early with an existing promise if available rather than creating any new resources. This will take a frame to resolve, but ensures that any in-process additions do finish before continuing.

Can we do the same early return for addSubRegion instead of creating a whole new function? It keeps the API footprint smaller and simplifies the control flow in _loadImage.

@ggetz I agree with your proposal and it has been fixed.

[ggetz]

Thanks @IKangXu!

[brunokunace]

@ggetz do you have any idea when a new version with this fix will be created?

[ggetz]

@brunokunace The fix went out in version 1.106 on June 1.