Fix rhumb line interpolate for 0 headings #11573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @ggetz!
Reviewers, don't forget to make sure that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rhumb line interpolation for headings of 0 degrees.
The error shows up in this (local) sandcastle
The fix is straightforward, but I'm getting reports that geojsons which previously worked are suddenly seeing this error. The confusing part is that it's reproducible in 1.110 and 1.109 (before the polygon changes went in), as well as versions 1.108 and before depending on whether or not they are using the zip file or the npm module. I'm thinking this is either a dependency or build discrepancy and looking further into it.