Fixes an issue with polygon hole rendering #11577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11583
This fixes an issue with polygon hole rendering that was introduced in https://github.com/CesiumGS/cesium/pull/11497/files. Holes were being projected to a slightly different tangent plane than the outer ring, which could result in slightly different coordinate systems between 2D outer positions and holes when triangulating holes with earcut.
You can see the error in the CZML Polygon demo.
Also reported on the forum with an example.