Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11716 visualize fog #11744

Merged
merged 60 commits into from
Jan 18, 2024
Merged

11716 visualize fog #11744

merged 60 commits into from
Jan 18, 2024

Commits on Dec 7, 2023

  1. Set up scaffolding for FogPipelineStage

    @ptrgags
    ptrgags committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    73146e0 View commit details
    Browse the repository at this point in the history

  2. Add atmosphere settings to FrameState and UniformState

    @ptrgags
    ptrgags committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    35c7d9d View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Make builtins for common atmosphere functions

    @ptrgags
    ptrgags committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    8723127 View commit details
    Browse the repository at this point in the history

  2. Get a barebones atmosphere shader compiling

    @ptrgags
    ptrgags committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    bf1890c View commit details
    Browse the repository at this point in the history

  3. Create Atmosphere object to propagate uniforms

    @ptrgags
    ptrgags committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    0634b53 View commit details
    Browse the repository at this point in the history

  4. Fix typos in uniform names

    @ptrgags
    ptrgags committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    d21e7bd View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into 4196-3d-tiles-fog

    @ptrgags
    ptrgags committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    0a2c338 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Temporary debugging code

    @ptrgags
    ptrgags committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    092f91e View commit details
    Browse the repository at this point in the history

  2. Use scene.fog to choose when fog stage is enabled

    @ptrgags
    ptrgags committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    6b7be7f View commit details
    Browse the repository at this point in the history

  3. Add a DynamicAtmosphereLightingType enum

    @ptrgags
    ptrgags committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    3027987 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Merge branch 'main' into 4196-3d-tiles-fog

    @ptrgags
    ptrgags committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    fb92f87 View commit details
    Browse the repository at this point in the history

  2. Document curvature directions in more detail

    @ptrgags
    ptrgags committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    a1cb8e1 View commit details
    Browse the repository at this point in the history

  3. Use a different method to compute the world position

    @ptrgags
    ptrgags committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    9fb4110 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Add unit test for Atmosphere

    @ptrgags
    ptrgags committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    bc781be View commit details
    Browse the repository at this point in the history

  2. Add unit tests for automatic uniforms

    @ptrgags
    ptrgags committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    990b815 View commit details
    Browse the repository at this point in the history

  3. Fix and update unit tests for ModelRuntimePrimitive

    @ptrgags
    ptrgags committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    c4e1b37 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into 11716-visualize-fog

    @ptrgags
    ptrgags committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    95b2a87 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Implement the other method for computing the ellipsoid position

    @ptrgags
    ptrgags committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    046160c View commit details
    Browse the repository at this point in the history

  2. Experiment with different ellipsoid calculations

    @ptrgags
    ptrgags committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    4255132 View commit details
    Browse the repository at this point in the history

  3. Remove temporary debugging code

    @ptrgags
    ptrgags committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    e3266df View commit details
    Browse the repository at this point in the history

  4. Have scene.atmosphere work when globe is off

    @ptrgags
    ptrgags committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    cc1f346 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. darken dynamic lighting

    @ptrgags
    ptrgags committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    bce6afc View commit details
    Browse the repository at this point in the history

  2. Remove dead function

    @ptrgags
    ptrgags committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    3112490 View commit details
    Browse the repository at this point in the history

  3. Remove debugging code

    @ptrgags
    ptrgags committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    b57ea04 View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @ptrgags
    ptrgags committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    bd7f7b9 View commit details
    Browse the repository at this point in the history

  5. Use common function for SkyAtmosphere

    @ptrgags
    ptrgags committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    c68e971 View commit details
    Browse the repository at this point in the history

  6. Remove debugging code

    @ptrgags
    ptrgags committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    a458be1 View commit details
    Browse the repository at this point in the history

  7. Remove unneeded file

    @ptrgags
    ptrgags committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    63efb02 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into 11716-visualize-fog

    @ptrgags
    ptrgags committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    138e4e2 View commit details
    Browse the repository at this point in the history

  9. Add a uniform for whether the tile is in fog

    @ptrgags
    ptrgags committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    e0314cd View commit details
    Browse the repository at this point in the history

  10. remove debugging code

    @ptrgags
    ptrgags committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    7d4e2fa View commit details
    Browse the repository at this point in the history

  11. Scattering is to be computed in the vertex shader

    @ptrgags
    ptrgags committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    d78360a View commit details
    Browse the repository at this point in the history

  12. Apply HSB shift

    @ptrgags
    ptrgags committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    59ab44d View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Fix model matrix spec

    @ptrgags
    ptrgags committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    3529441 View commit details
    Browse the repository at this point in the history

  2. Async-ify model matrix update stage

    @ptrgags
    ptrgags committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f8d3560 View commit details
    Browse the repository at this point in the history

  3. Move pipeline stage specs to ModelSceneGraph

    @ptrgags
    ptrgags committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    af06785 View commit details
    Browse the repository at this point in the history

  4. fix auto imports

    @ptrgags
    ptrgags committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    4e6b942 View commit details
    Browse the repository at this point in the history

  5. Add test for czm_fogMinimumBrightness

    @ptrgags
    ptrgags committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    cdc24fc View commit details
    Browse the repository at this point in the history

  6. Add specs for FogPipelineStage

    @ptrgags
    ptrgags committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    19cd032 View commit details
    Browse the repository at this point in the history

  7. async-ify model scene graph tests

    @ptrgags
    ptrgags committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    7e4e6e1 View commit details
    Browse the repository at this point in the history

  8. Update documentation

    @ptrgags
    ptrgags committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    393e7fc View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into 11716-visualize-fog

    @ptrgags
    ptrgags committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    55db725 View commit details
    Browse the repository at this point in the history

  10. Add specs for DynamicAtmosphereLightingType

    @ptrgags
    ptrgags committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    9b4c846 View commit details
    Browse the repository at this point in the history

  11. Rename FogPipelineStage -> AtmospherePipelineStage

    @ptrgags
    ptrgags committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    e0f9b33 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. add render tests for model fog

    @ptrgags
    ptrgags committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5236406 View commit details
    Browse the repository at this point in the history

  2. Fix atmosphere pipeline specs

    @ptrgags
    ptrgags committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    920ed28 View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @ptrgags
    ptrgags committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    dbbd50b View commit details
    Browse the repository at this point in the history

  4. Update documentation based on PR feedback

    @ptrgags
    ptrgags committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    060eb47 View commit details
    Browse the repository at this point in the history

  5. Add missing JSDoc tags

    @ptrgags
    ptrgags committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    7592fa4 View commit details
    Browse the repository at this point in the history

  6. Mark specs as requiring WebGL

    @ptrgags
    ptrgags committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    7b930e2 View commit details
    Browse the repository at this point in the history

  7. Reset atmosphere after each render test

    @ptrgags
    ptrgags committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    84e77ea View commit details
    Browse the repository at this point in the history

  8. Add a separate bullet for adding scene.atmosphere

    @ptrgags
    ptrgags committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    6c2af2f View commit details
    Browse the repository at this point in the history

  9. Don't mock in AtmospherePipelineStageSpec

    @ptrgags
    ptrgags committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    defd310 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. address PR feedback

    @ptrgags
    ptrgags committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    dca2dcf View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. add ignoreBlackPixels option to czm_applyHSBShift

    @ptrgags
    ptrgags committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    7adf61d View commit details
    Browse the repository at this point in the history

  2. use czm_tanh()

    @ptrgags
    ptrgags committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    6cefbe1 View commit details
    Browse the repository at this point in the history

  3. Store the Atmosphere in the FrameState directly

    @ptrgags
    ptrgags committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    ac17f63 View commit details
    Browse the repository at this point in the history

  4. Fix automatic uniform specs

    @ptrgags
    ptrgags committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    bca110f View commit details
    Browse the repository at this point in the history

  5. Fix sky atmosphere

    @ptrgags
    ptrgags committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    3a25627 View commit details
    Browse the repository at this point in the history

  6. Update unit tests

    @ptrgags
    ptrgags committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    ab97280 View commit details
    Browse the repository at this point in the history