Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two failing specs:
The
GroundPolylinePrimitive
spec is a fragile test that was broken by new terrain heights. See #11807.The
Model
spec failure was caused by an unrealistic expectation in the initial test suite from #11744. The assumption was that when the sun is on the opposite side of the earth, the model will appear dark but not exactly black. However, in a spec canvas it does sometimes render as fully black.The remaining expectations in this spec are sufficient, so I simply deleted the unreliable one.
Testing plan
Verify
GroundPolylinePrimitiveSpec
andModelSpec
run through locally without errors (CI didn't catch the problems).Author checklist
CONTRIBUTORS.md
[ ] I have updatedCHANGES.md
with a short summary of my change[ ] I have update the inline documentation, and included code examples where relevant