Tolerate (but don't fully render) complex polygons #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 27, 2013 17:25
This patches the problem with complex polygons completely failing triangulation. Instead, complex areas of the polygon will not render, but instead be skipped over. This allows polygons which are have only small "complexities" to still render (almost) correctly.
|
Thanks @DavidHudlow. This is a reasonable approach for b21. I'll test the JSON files now. There is a test failure that I fixed in #1208 (another test was wrong). In general, always run the tests before opening a pull request. |
|
This works well. I'll merge after #1208 is merged. |
|
@pjcozzi I just merged your PR, you are good to merge this. |
|
That was fast, thanks. |
pjcozzi
added a commit
that referenced
this pull request
Sep 30, 2013
Tolerate (but don't fully render) complex polygons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches the problem with complex polygons completely failing
triangulation. Instead, complex areas of the polygon will not render,
but instead be skipped over. This allows polygons which are have only small
"complexities" to still render (almost) correctly.
Should get b21 in shape until complex polygon rendering can be sorted out.
(Fix #1121)