Add support for glTF normalTextureInfo.scale #12018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The glTF specification describes a scale that can be applied to the values read from a normal texture. This scalar applies to the
.x
and.y
components only.This PR adds a
.scale
property toModelComponents.TextureReader
, and adds code to process the scale inGltfLoaderUtil
andMaterialPipelineStage
. In the shader, the scalar is applied (if present) inMaterialStageFS
.Here is the Clearcoat Car Paint test model in CesiumJS 1.118:
With this PR:
Comparing to the glTF Sample Viewer
Issue number and link
Resolves #6948.
Testing plan
Load the glTF PBR Extensions Sandcastle and compare the Clearcoat Car Paint model to the rendering in the glTF Sample Viewer
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change