Fix icons in deployed Sandcastle #12029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @ggetz! ✅ We can confirm we have a CLA on file for you. |
jjspace
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes erroneous icon files deployed to sandcastle.cesium.com.
Similar to #12016, this was a misconfiguration of gulp.
I'm pretty sure that this is the last of the issues with deployed Sandcastle, but please double check me.
Issue number and link
Fixes #12026
Testing plan
PROD=true npm run website-releasePROD=true npm run build-appsnpm start -- --productionand navigate tohttp://localhost:8080/Build/Sandcastle/index.html?src=3D%20Models.htmlAuthor checklist
CONTRIBUTORS.mdI have updatedCHANGES.mdwith a short summary of my changeI have added or updated unit tests to ensure consistent code coverageI have update the inline documentation, and included code examples where relevant