Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Property 'availability' is missing in type 'CustomHeightmapTerrai… #12042

Conversation

Tim-S
Copy link
Contributor

@Tim-S Tim-S commented Jun 19, 2024

…nProvider' but required in type 'TerrainProvider' when using with typescript

Description

When try using CustomHeightmapTerrainProvider from a small typescript toy-project I got a

Property 'availability' is missing in type 'CustomHeightmapTerrainProvider' but required in type 'TerrainProvider'

added simple default Implementation in CustomHeightmapTerrainProvider (basically same as in EllipsoidTerrainProvider)

to make the basic CustomHeightmapTerrainProvider from the doc work

Issue number and link

Testing plan

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have update the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

Thank you for the pull request, @Tim-S!

✅ We can confirm we have a CLA on file for you.

Copy link
Contributor

@ggetz ggetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tim-S for the fix! Overall this looks good, just one change requested from me.

Please also add a summary of your change to CHANGES.md, as this does fix functionality for those using TS.

@Tim-S Tim-S force-pushed the fix-ts-Property-availability-is-missing-in-type-CustomHeightmapTerrainProvider-but-required-in-type-TerrainProvider branch from 422440c to 5e19cf1 Compare June 20, 2024 19:09
@Tim-S Tim-S requested a review from ggetz June 20, 2024 19:16
@ggetz
Copy link
Contributor

ggetz commented Jun 24, 2024

Awesome, thanks @Tim-S!

@ggetz ggetz merged commit 555ff0e into CesiumGS:main Jun 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants