Add multiscattering terms to diffuse BRDF in image-based lighting #12118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds terms to the diffuse BRDF in image-based lighting, to account for multiple scattering. The math follows a paper by Fdez-Aguera. For a somewhat more gentle introduction, see this practical summary by Bruno Opsenica.
Rendering comparison
Before this PR:
After this PR:
Some key changes to notice:
Issue number and link
Resolves #12028. (This is the last of a series of fixes addressing that issue).
Testing plan
main
branch, as well as to the glTF Sample Viewer.main
branch and to the results in Bruno Opsenica's blog post.Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change[ ] I have added or updated unit tests to ensure consistent code coverageSee Add screenshot testing for subtle lighting changes #12065