Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing render specs for MSAA defaults #12165

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Fix failing render specs for MSAA defaults #12165

merged 1 commit into from
Aug 29, 2024

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Aug 28, 2024

Description

Many rendering specs were failing locally after adjusting the MSAA default. This fixes them.

  1. When the rendering context is too small (like many of the test, which run in a 1x1 canvas), it always appears black when MSAA is enabled.
  2. Some tests explicitly need MSAA to be turned off, ie. line weight tests.

Issue number and link

N/A

Testing plan

Run specs locally. They should be passing (or in a similar state to main pre-#12158)

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@ggetz ggetz requested a review from jjspace August 28, 2024 16:59
Copy link

Thank you for the pull request, @ggetz!

✅ We can confirm we have a CLA on file for you.

@ggetz
Copy link
Contributor Author

ggetz commented Aug 28, 2024

@jjspace Can you please review?

Copy link
Contributor

@jjspace jjspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm after switching branches to run tests multiple times they now pass as I'd expect before my msaa pr. I'm sorry for missing them in that one 🙏

@jjspace jjspace merged commit d267eb2 into main Aug 29, 2024
10 checks passed
@jjspace jjspace deleted the msaa-specs branch August 29, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants