-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CallbackPositionProperty #12170
Conversation
Thank you for the pull request, @jfayot! ✅ We can confirm we have a CLA on file for you. |
Thanks @jfayot! We'll review this shortly, likely early next week. If we merge, it will go into the October 1 release. |
This is ready 👀 |
Thank you for your patience @jfayot! I will be able to do a full review tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @jfayot! And this is a fantastic Sandcastle example too!
A few small comments, but otherwise the code is looking great. Thanks again for the PR!
Thanks for the review @ggetz ! Updated according to your comments. Should I resolve conflicts ? |
Resolved conflicts, should be ready to merge, but you'd better double check, I'm not a git expert... |
Looks great! Thanks again @jfayot! |
Description
This is a proposal for a
CallbackPositionProperty
, without making TS expose Property types as generics as mentioned hereIssue number and link
Testing plan
Added specific spec file with 100% coverage on the
CallbackPositionProperty
class.Updated
PathVizualizer
spec file to allowCallbackPositionProperty
sub-sampling.Added a specific sandcastle demo.
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change