-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base zoom speed on browser refresh rate #12211
Draft
lukemckinstry
wants to merge
4
commits into
main
Choose a base branch
from
framerate-over-time
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+52
−1
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5011221
add timeStamps array field to frame state
lukemckinstry 911b27b
add update frame state time stamps array to scene render function
lukemckinstry a09d9eb
calculate and use frames per second in handle zoom func
lukemckinstry b5ac693
refactor to fps tracker class
lukemckinstry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import destroyObject from "../Core/destroyObject.js"; | ||
import getTimestamp from "../Core/getTimestamp.js"; | ||
|
||
/** | ||
* @private | ||
*/ | ||
function FpsTracker(options) { | ||
this._timeStamps = []; | ||
} | ||
|
||
/** | ||
* Calculates average fps based on timeStamps of recently rendered frames | ||
*/ | ||
FpsTracker.prototype.getAverageFps = function () { | ||
if (this._timeStamps.length !== 10) { | ||
return; | ||
} | ||
const elapsedTime = (this._timeStamps[0] - this._timeStamps[9]) / 9; | ||
const fps = 1 / (elapsedTime / 1000); | ||
return fps; | ||
}; | ||
|
||
/** | ||
* Adds the timestamp for the current frame to the queue | ||
*/ | ||
FpsTracker.prototype.updateFrameTimeStamp = function () { | ||
const time = getTimestamp(); | ||
this._timeStamps.unshift(time); | ||
if (this._timeStamps.length > 10) { | ||
this._timeStamps.pop(); | ||
} | ||
}; | ||
|
||
/** | ||
* Destroys the WebGL resources held by this object. | ||
*/ | ||
FpsTracker.prototype.destroy = function () { | ||
return destroyObject(this); | ||
}; | ||
export default FpsTracker; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are accessing this from another class, can we expose this as
fpsTracker
with a getter? It can be marked as@private
so it doesn't show up in the developer API documentation.