Detect and parse data URIs in loadWithXhr #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * 'X-Custom-Header' : 'some value' | ||
| * }).then(function(document) { | ||
| * //Do something with the document | ||
| * }, function() { |
There was a problem hiding this comment.
I could be mistaken, but doesn't this callback provide an error object when it fails? If so we should add it, since this is example code and people might not realize it.
There was a problem hiding this comment.
Yeah. I copied this from other places. I updated them all to include the error parameter.
|
Just the one question/comment. Other than that this looks good and tests pass in Chrome/Firefox/IE11 |
|
This also probably warrants a CHANGES update, since we now support data uris in our loadXXX functions. |
|
Fair enough, I added it to Dr. Changes, MD. |
mramato
added a commit
that referenced
this pull request
Mar 4, 2014
Detect and parse data URIs in loadWithXhr
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful for loading CZML documents with embedded glTF models.