Visualizer cleanup #1653
Merged
Visualizer cleanup #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Source/DynamicScene/DataSourceDisplay.js
It turns out a `Visualizer` instance only needs `update` and `destroy` functions. Also start cleaning up other visualizer to conform to the interface and remove uneeded cruft.
Conflicts: Apps/CesiumViewer/CesiumViewer.js Source/Widgets/Viewer/viewerDragDropMixin.js
| * DynamicObject counterpart at the given time. | ||
| * @memberof DynamicLabelVisualizer |
There was a problem hiding this comment.
should be DynamicConeVisualizerUsingCustomSensor. Same for destroy.
There was a problem hiding this comment.
Thought I caught all of these. Thanks.
Fix DynamicConeVisualizerUsingCustomSensor doc. Use already obtained local variable in DynamicPointVisualizer.prototype.destroy Remove unecessary if checks.
1. Put back isDestroyed function. 2. Document Visualizer functions correctly.
|
Ready for another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some long overdue Visualizer clean up and simplification. After we introduced
DataSourceDisplay, a lot of the functions on the visualizers became unnecessary. This removessetDynamicObjectCollection,getDynamicObjectCollection,getScene, andremoveAllPrimitivesfrom all visualizers and defines a simpleVisualizerbase interface for the documentation. I also cleaned up Visualizer related documentation. There are no real functional changes to any of this code; it's just a stepping stone to clean everything up before rewriting/optimizing our older visualizers.