Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial KML support #2503

Merged
merged 379 commits into from
Mar 1, 2015
Merged

Initial KML support #2503

merged 379 commits into from
Mar 1, 2015

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Feb 20, 2015

  1. The changes to the public API are extremely minor, it simply adds a new object, KmlDataSource, which is the same as other data sources but for KML. It only has 3 functions. (fromUrl, load, loadUrl).
  2. Also adds KML and KMZ support to viewerDragDropMixin and the Cesium Viewer app source parameter.
  3. I've been keeping KML Support #873 up to date with what's done and what's not for overall KML support, check that out if you want to see what we support/don't support yet.
  4. Do not look at SurfacePositionProperty at yet, I still have a lot of work to do on this class (including renaming it). I'll update this PR when it's ready. No matter what, it will be private for 1.7 since we still need to figure out the exact details of height reference support. This is more about laying ground work.

Also, just a reminder that you'll want to either set InfoBoxViewModel.defaultSanitizer to undefined or comment out line 161 of InfoBoxViewModel when you're playing with this in order to avoid balloon descriptions getting neutered. I plan on addressing this in an unrelated pull (hopefully before 1.7). You'll also want to use the proxy if you play with public Network Links.

ToDo before Merge

  • Rename SurfacePositionProperty to ScaledPositionProperty and finish initial height reference support
  • Verify how styles are applied and write tests for each type of Entity that gets created.
  • Test DataSource clock and changed/error/loading events
  • Replace Sandcastle example and sample KML data, also snap new gallery image.
  • Update CHANGES
  • Improve ref doc and explain the Entity.kml property that gets added.

Also perform some minor clean up and optimizations.
Also detect full alpha properly.
@mramato
Copy link
Contributor Author

mramato commented Feb 27, 2015

Okay, this branch is ready for more eyeballs. I still want to do another full review myself, but I don't plan on making any additional changes outside of review comments (or any issues I find myself).

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 27, 2015

@mramato I can merge this over the weekend or wait until early Monday if you prefer to get more time for reviews...

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 27, 2015

Do we have to update the bottom of LICENSE.md for any of the example or test data?

@mramato
Copy link
Contributor Author

mramato commented Feb 27, 2015

We're had the us_states (as CZML) on on the website forever, but I'm not sure where it came from. I'll have to dig around.

The GDP example was created with http://www.kmlfactbook.org/ and uses Public Domain data, so I think we are in the clear there.

Everything else originated from AGI (facilities) or is of my own creation. (bikeRide and test data).

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 27, 2015

We can file a separate bug on this if @mramato and @bagnell want: in the KML Sandcastle example, open the bike ride KML. Switch to 2D and zoom in. Switch to Columbus View and it freezes the tab.

@mramato
Copy link
Contributor Author

mramato commented Feb 27, 2015

There seems to be two bugs here. 1) a bug introduced in 1.6 that is triggered by morphing while tracking something and 2) Another manifestation of #2401, which still only happens in Chrome.

I fixed 1 in this branch. 2 still happens in Chrome., I'll reopen #2401.

@mramato mramato mentioned this pull request Feb 27, 2015
@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 28, 2015

@mramato can we merge or are you still tweaking this?

@mramato
Copy link
Contributor Author

mramato commented Mar 1, 2015

As we discussed offline, I removed the us_states KML and example, since usage rights are no clearly defined. We can add back a similar example in the future if we ever find (or make) one.

This is ready to be merged.

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 1, 2015

IE 11 performance is really bad. The GDP per capita example takes about a minute to load on my machine. Perhaps it is their Web Worker implementation.

pjcozzi added a commit that referenced this pull request Mar 1, 2015
@pjcozzi pjcozzi merged commit 4b151fd into master Mar 1, 2015
@mramato
Copy link
Contributor Author

mramato commented Mar 1, 2015

That's weird. It only takes 10 seconds on my laptop, which is running Windows 8.1 and IE Version: 11.0.9600.17631 and Update Versions: 11.0.16 (KB3021952)

@mramato
Copy link
Contributor Author

mramato commented Mar 1, 2015

For reference, my laptop is a 2 year old i5-3320 running at 2.60GHz (dual core). It was also using the HD 4000 at the time (now that it should matter for load).

@pjcozzi pjcozzi deleted the kml branch March 1, 2015 21:32
@mramato mramato mentioned this pull request Mar 2, 2015
70 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants