-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial KML support #2503
Initial KML support #2503
Conversation
Also ran the foramtter.
Style and coordinate fixes.
Also perform some minor clean up and optimizations.
Okay, this branch is ready for more eyeballs. I still want to do another full review myself, but I don't plan on making any additional changes outside of review comments (or any issues I find myself). |
@mramato I can merge this over the weekend or wait until early Monday if you prefer to get more time for reviews... |
Do we have to update the bottom of LICENSE.md for any of the example or test data? |
We're had the us_states (as CZML) on on the website forever, but I'm not sure where it came from. I'll have to dig around. The GDP example was created with http://www.kmlfactbook.org/ and uses Public Domain data, so I think we are in the clear there. Everything else originated from AGI (facilities) or is of my own creation. (bikeRide and test data). |
Also added a test fo rit.
Also fix JSHint error.
@mramato can we merge or are you still tweaking this? |
As we discussed offline, I removed the us_states KML and example, since usage rights are no clearly defined. We can add back a similar example in the future if we ever find (or make) one. This is ready to be merged. |
IE 11 performance is really bad. The GDP per capita example takes about a minute to load on my machine. Perhaps it is their Web Worker implementation. |
That's weird. It only takes 10 seconds on my laptop, which is running Windows 8.1 and IE |
For reference, my laptop is a 2 year old i5-3320 running at 2.60GHz (dual core). It was also using the HD 4000 at the time (now that it should matter for load). |
KmlDataSource
, which is the same as other data sources but for KML. It only has 3 functions. (fromUrl
,load
,loadUrl
).viewerDragDropMixin
and the Cesium Viewer appsource
parameter.SurfacePositionProperty
at yet, I still have a lot of work to do on this class (including renaming it). I'll update this PR when it's ready. No matter what, it will be private for 1.7 since we still need to figure out the exact details of height reference support. This is more about laying ground work.Also, just a reminder that you'll want to either set
InfoBoxViewModel.defaultSanitizer
toundefined
or comment out line 161 ofInfoBoxViewModel
when you're playing with this in order to avoid balloon descriptions getting neutered. I plan on addressing this in an unrelated pull (hopefully before 1.7). You'll also want to use the proxy if you play with public Network Links.ToDo before Merge
SurfacePositionProperty
toScaledPositionProperty
and finish initial height reference supportEntity.kml
property that gets added.