Zoom to mouse cursor #2810
Zoom to mouse cursor #2810
Conversation
|
In 2D, zoom in close from a global view. It feels too fast once we're close. |
|
Does this disable inertia for zoom in 2D and Columbus view? |
|
It seems like zoom inertia shuts off in 3D in some cases too. |
|
From a default view in 3D, a quick - but reasonable zoom - leads to too much jerk in the zoom path. |
Do you have steps to reproduce this? Does it happen after switching between scene modes? I haven't seen it. |
|
Seems to happen to all seen modes after doing some middle click drag to 360 rotate around a point of interest. |
|
It's possible to get into a case like this:
From the home view, I left dragged to a point over the north pole so when I zoomed in the up vector was pointing south, then I went to the south pole. |
| @@ -161,6 +161,11 @@ defineSuite([ | |||
| var ellipsoid = Ellipsoid.WGS84; | |||
There was a problem hiding this comment.
Is this enough tests to cover all the new code?
|
@pjcozzi This is ready for another look. The zoom in 3D and 2D should be much better. The zoom in Columbus view is the same. |
|
I got this exception when I took this horizon view in beautiful North Wildwood:
|
|
This doesn't reproduce it, but here is the link: http://localhost:1234/Apps/CesiumViewer/index.html?view=-74.79584484288888%2C38.994487937529996%2C22.77024267599088%2C50.52363135127272%2C0.2574589130355182%2C0.14517617284116282 |
|
Crash when zooming into the baseball field in the middle of the screen:
http://localhost:1234/Apps/CesiumViewer/index.html?view=NaN%2CNaN%2CNaN%2CNaN%2CNaN%2CNaN Note the NANs above. The was was similar to: |
|
It takes two or three times to reproduce it, but start at the southeast corner of Wildwood: Then right click zoom the northeast tip of the North Wildwood beach and zoom in quickly. Sometimes it is perfect; sometimes it slides along the ground awkwardly; and one time, it left me around South Carolina. |
|
Zooming over the north pole makes it easy to get into a situation where middle mouse drag is reversed or the horizon is tilted:
|
|
From the home view in CV, click on Alaska then zoom in:
|
|
Terrain was on in the CV scenario above. |
|
The CV zoom crash is pretty easy to reproduce on any zoom and without terrain. |
|
This crash is probably duplicate with the other
|
|
Can we make this work with 3D models using |
It already does, but the camera height has to be less than |
…ts toward the horizon. Fix zoom in Columbus view.
|
@pjcozzi This is ready for another look. I couldn't reproduce many of the crashes after I fixed a couple. I'll try for a little while longer and post if I can. |
|
I can still reproduce this exception. I was zoomed in to Yosemite with terrain on, then I left click panned a bit to a distant mountain peak, followed by right click zoom to the same peak:
|
|
Everything else looks good. This is the only issue left that I can reproduce. Also, merge in master. |
Conflicts: CHANGES.md
… when zooming in 3D.
|
@pjcozzi This is ready for another look. The last crash is fixed. To reliably reproduce the crash, make sure terrain is on, the sky is at the center of the screen and right click zoom on terrain. |
|
Looks good! |
Changes the default zoom behavior to zoom to the point under the mouse cursor. #302, #1060