Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BillboardCollection bounding sphere #2900

Merged
merged 5 commits into from
Jul 24, 2015
Merged

Fix BillboardCollection bounding sphere #2900

merged 5 commits into from
Jul 24, 2015

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jul 23, 2015

Fixes #2894

image

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 23, 2015

Thanks @hpinkos.

Update CHANGES.md.

@bagnell can you review this? Do we have tests for this? It should be reasonable enough to write good tests here.

@bagnell
Copy link
Contributor

bagnell commented Jul 24, 2015

@hpinkos The changes look good. There are no unit tests for this, but you can add one that checks that the bounding sphere is only smaller where both the vertical and horizontal origins are the center.

hpinkos added 2 commits July 24, 2015 15:04
@hpinkos
Copy link
Contributor Author

hpinkos commented Jul 24, 2015

@bagnell ready

bagnell added a commit that referenced this pull request Jul 24, 2015
@bagnell
Merge pull request #2900 from AnalyticalGraphicsInc/issue2894
4cfd97a 
Fix BillboardCollection bounding sphere
@bagnell bagnell merged commit 4cfd97a into master Jul 24, 2015
@bagnell bagnell deleted the issue2894 branch July 24, 2015 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hpinkos @pjcozzi @bagnell