Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Czml examples tweaks #3072

Merged
merged 14 commits into from
Oct 14, 2015
Merged

Czml examples tweaks #3072

merged 14 commits into from
Oct 14, 2015

Conversation

sen-lu
Copy link
Contributor

@sen-lu sen-lu commented Oct 14, 2015

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 14, 2015

The CZML Path example is a little awkward since it uses the facility billboard as the moving object. @mramato do we have anything handy that would be reasonable to use here?

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 14, 2015

@TiffanyLu @adamdavidcole nice job, at quick glance, that is the only comment I have.

@mramato is going to also do a quick review.

@mramato
Copy link
Contributor

mramato commented Oct 14, 2015

@mramato do we have anything handy that would be reasonable to use here?

I found some public domain hangliding icons at https://thenounproject.com/term/hang-gliding/239/. Since it's public domain, we don't even need to credit it.

If you don't want to use one of those, we can probably grab the aircraft icon we use in STK or just make it a point instead of a billboard. I'm open to suggestions.

@mramato
Copy link
Contributor

mramato commented Oct 14, 2015

Thanks guys. The one outstanding problem is still the thumbnails. They are way bigger (file size wise and resolution-wise) than all of the other thumbnails. I'm sorry I didn't give you better instructions in the previous issue I wrote up. The should all be 225x150. Normally we use the "Show as Thumbnail" button at the top of Sandcastle to create them. In this case, just resizing the ones you already made should be pretty easy, no need to resnap them all. We also usually save at 95% quality jpg. Sorry again for the confusion.

Other than that, (and @pjcozzi's comment) this looks great.

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 14, 2015

I suspect they are bigger than usual because of the Retina display...I run into it all the time.

@sen-lu
Copy link
Contributor Author

sen-lu commented Oct 14, 2015

I do indeed have the Retina display... even after resizing the screenshots and saving them as high or medium (as opposed to maximum) quality, they were still much larger, resolution-wise, than the others. I just ran all of them through ImageOptim and I think they should be fine now. So hopefully that's everything, and we're ready!
@pjcozzi @mramato

@mramato
Copy link
Contributor

mramato commented Oct 14, 2015

Thanks guys! Nice work.

mramato added a commit that referenced this pull request Oct 14, 2015
@mramato mramato merged commit 65eb4bf into CesiumGS:master Oct 14, 2015
@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 14, 2015

Thanks for the review @mramato.

Awesome job @TiffanyLu @adamdavidcole! Good luck with #2814.

@sen-lu sen-lu deleted the czml-examples-tweaks branch October 14, 2015 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CZML Example improvements
3 participants