-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Czml examples tweaks #3072
Czml examples tweaks #3072
Conversation
The CZML Path example is a little awkward since it uses the facility billboard as the moving object. @mramato do we have anything handy that would be reasonable to use here? |
@TiffanyLu @adamdavidcole nice job, at quick glance, that is the only comment I have. @mramato is going to also do a quick review. |
I found some public domain hangliding icons at https://thenounproject.com/term/hang-gliding/239/. Since it's public domain, we don't even need to credit it. If you don't want to use one of those, we can probably grab the aircraft icon we use in STK or just make it a point instead of a billboard. I'm open to suggestions. |
Thanks guys. The one outstanding problem is still the thumbnails. They are way bigger (file size wise and resolution-wise) than all of the other thumbnails. I'm sorry I didn't give you better instructions in the previous issue I wrote up. The should all be 225x150. Normally we use the "Show as Thumbnail" button at the top of Sandcastle to create them. In this case, just resizing the ones you already made should be pretty easy, no need to resnap them all. We also usually save at 95% quality jpg. Sorry again for the confusion. Other than that, (and @pjcozzi's comment) this looks great. |
I suspect they are bigger than usual because of the Retina display...I run into it all the time. |
I do indeed have the Retina display... even after resizing the screenshots and saving them as high or medium (as opposed to maximum) quality, they were still much larger, resolution-wise, than the others. I just ran all of them through ImageOptim and I think they should be fine now. So hopefully that's everything, and we're ready! |
Thanks guys! Nice work. |
Thanks for the review @mramato. Awesome job @TiffanyLu @adamdavidcole! Good luck with #2814. |
close #3063
@pjcozzi @mramato @adamdavidcole