Default failIfMajorPerformanceCaveat to false #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid users first impression of Cesium being a failed to load screen, this changes failIfMajorPerformanceCaveat back to the official WebGL default of `false`. While I agree that many Cesium apps will perform poorly under these conditions, there are several use cases where it makes sense, such as RDP sessions. I also removed an old Firefox workaround for Firefox 35. Since 35 was not an ESR release, there's no reason for the workaround to still be there.
pjcozzi
added a commit
that referenced
this pull request
Oct 20, 2015
…manceCaveat Default failIfMajorPerformanceCaveat to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid users' first impression of Cesium being a failed to load screen, this changes
failIfMajorPerformanceCaveatback to the official WebGL default offalse. While I agree that many Cesium apps will perform poorly under these conditions, there are several use cases where it makes sense, such as RDP sessions. I also think it's better to provide maximum compatibility out of the box since almost no user will know about or ever use this setting.I also removed an old Firefox workaround for Firefox 35. Since 35 was not an ESR release, there's no reason for the workaround to still be there.
P.S. Context.js apparently had some lines with nothing but whitespace that the Eclipse formatter cleaned up, which is why those extra blank changes are there.