MapboxImageryProvider: high-DPI (@2x) support #3899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devyn thanks for this contribution! Can you please send in a Contributor License Agreement (CLA) so we can review this? |
|
@devyn thanks again! Can you please send in a Contributor License Agreement (CLA) so someone can review this? |
mramato
added a commit
that referenced
this pull request
Oct 19, 2016
This just allows `format` to be anything, rather than forcing it to start with a `.` which provides the flexibility for specifying `@2x.png`. Replaces #3899.
|
Hi @devyn, since we never received a CLA from you, we're unable to review/merge this. I'm opening a separate pull request to solve this problem in a slightly different way so the feature will still get added. Thanks anyway, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapbox supports retina/2x high-DPI images by prepending '@2x' to the URL right before the dot and the format.
This commit adds a boolean option to
MapboxImageProvidercalledretina(default:false) to control this.