Fixed Matrix4.fromCamera #3946
Merged
Fixed Matrix4.fromCamera #3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,6 +21,7 @@ Change Log | |||
| * Added `terrainProviderChanged` event to `Scene` and `Globe` | |||
| * Added `CullingVolume.fromBoundingSphere`. | |||
| * Added `debugShowShadowVolume` to `GroundPrimitive`. | |||
| * Fixed issue where Matrix4.fromCamera was taking eye/target instead of position/direction. [3927](https://github.com/AnalyticalGraphicsInc/cesium/issues/3927) | |||
There was a problem hiding this comment.
Small issue I just noticed, Matrix4.fromCamera should be surrounded by `` like the other items for markdown styling purposes.
|
Looks good! Congrats on your first Cesium pull request. |
|
Thanks @JoshuaStorm! Congrats on your first PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3927
Fixed issue where Matrix4.fromCamera was taking eye/target instead of position/direction.