Vanishing atmosphere when looking up #3347 #3965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now we can view the solar eclipse on September 1st of this year! As seen from Madagascar:
|
|
Nice fix! |
|
Wow great fix, thanks @likangning93! Can you please post to this thread (linked from #3347) and let them know that this is fixed and will be in Cesium 1.22 next Wednesday? Also, if you are interested in solar eclipse, see http://cesiumjs.org/2015/03/19/EclipseTracks-Interactive-Solar-Eclipses-with-Cesium/ |
|
Now you just need to make the sky goes dark and the moon casts a shadow on the Earth :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #3347
It seems like this problem was caused by commit 4cccade. I think this was to prevent the atmosphere from rendering before tiles were ready, but the way it was handled caused the atmosphere to vanish if no tiles were being rendered (fully skyward view).
Also updated CHANGES.md.
