Fixed typo when creating GroundPrimitives. #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -138,8 +138,10 @@ | |||
| } | |||
| }]; | |||
|
|
|||
| var viewer = new Cesium.Viewer('cesiumContainer'); | |||
| viewer.dataSources.add(Cesium.CzmlDataSource.load(czml)); | |||
| Cesium.GroundPrimitive.initializeTerrainHeights().then(function() { | |||
There was a problem hiding this comment.
Why is this needed here? The Entity visualization system should already be doing this automatically for the user, if it's not then we need to add code to make that happen; not force users to do it themselves.
added 2 commits
August 2, 2016 10:32
… Added a test that makes sure update returns false till the terrain heights promise resolves.
|
@mramato Should be good to go. |
|
There are some failing tests. |
… where we need them and uninitialize when done, so we don't effect other tests.
|
Thanks @tfili! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GroundPrimitiveschanged its interface to accept more than oneGeometryInstanceat some point and the dynamic geometries that used them weren't updated.Not exactly sure how to test this, as I can't verify a primitive has any
GeometryInstances once its created by the dynamic geometry updater.CC #4160 @hpinkos